Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r2004535984
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +565,134 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
+ if (crs != null) {
+ Preconditions.checkArgument(!crs.isEmpty(), "Invalid CRS: (empty
string)");
+ Preconditions.checkArgument(
Review Comment:
Constructing a GeometryType manually using `GeometryType.of(" crs_value ")`
and retrieve its CRS will result in a different value if we trim it. I've asked
for it here https://github.com/apache/iceberg/pull/12346#discussion_r1996626058
and decided to throw exception to avoid any unexpected behavior for such cases.
I can change it to silently trimming the input if you consider it a more
appropriate approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
