danielcweeks commented on code in PR #12581:
URL: https://github.com/apache/iceberg/pull/12581#discussion_r2006421739
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/InternalWriter.java:
##########
@@ -40,11 +40,15 @@ public class InternalWriter<T extends StructLike> extends
BaseParquetWriter<T> {
private InternalWriter() {}
+ /**
+ * @deprecated will be removed in 1.10.0; use {@link #createWriter(Schema,
MessageType)} instead.
+ */
+ @Deprecated
public static <T extends StructLike> ParquetValueWriter<T>
create(MessageType type) {
return create((Types.StructType) null, type);
}
- public static <T extends StructLike> ParquetValueWriter<T> create(
+ public static <T extends StructLike> ParquetValueWriter<T> createWriter(
Review Comment:
I don't love this because we now have a confusing combination of `create`,
`createWriter` and `buildWriter` floating around, but I also couldn't find a
good alternative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
