rdblue commented on code in PR #12581:
URL: https://github.com/apache/iceberg/pull/12581#discussion_r2005949897
##########
orc/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriter.java:
##########
@@ -156,8 +156,8 @@ public Stream<FieldMetrics<?>> metrics() {
private static class RecordWriter extends
GenericOrcWriters.StructWriter<Record> {
- RecordWriter(List<OrcValueWriter<?>> writers) {
- super(writers);
+ RecordWriter(Types.StructType struct, List<OrcValueWriter<?>> writers) {
+ super(struct, writers);
Review Comment:
We will. Right now, Spark writers and Flink ORC writers don't support the
new types so they don't need to be updated in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
