rdblue commented on code in PR #12581:
URL: https://github.com/apache/iceberg/pull/12581#discussion_r2004240939
##########
core/src/test/java/org/apache/iceberg/data/DataTest.java:
##########
@@ -148,7 +148,11 @@ public void testTypeSchema(Type type) throws IOException {
.as("variant is not yet implemented")
.isTrue();
- writeAndValidate(new Schema(required(1, "id", LongType.get()), optional(2,
"test_type", type)));
+ writeAndValidate(
+ new Schema(
+ required(1, "id", LongType.get()),
+ optional(2, "test_type", type),
+ required(3, "trailing_data", Types.StringType.get())));
Review Comment:
Without correct alignment, this test will fail for unknown when the `null`
value for field 2 is passed to the writer for field 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
