rdblue commented on code in PR #12581:
URL: https://github.com/apache/iceberg/pull/12581#discussion_r2004250123
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/InternalWriter.java:
##########
@@ -40,11 +40,15 @@ public class InternalWriter<T extends StructLike> extends
BaseParquetWriter<T> {
private InternalWriter() {}
+ /**
+ * @deprecated will be removed in 1.10.0; use {@link #createWriter(Schema,
MessageType)} instead.
+ */
+ @Deprecated
public static <T extends StructLike> ParquetValueWriter<T>
create(MessageType type) {
return create((Types.StructType) null, type);
}
- public static <T extends StructLike> ParquetValueWriter<T> create(
+ public static <T extends StructLike> ParquetValueWriter<T> createWriter(
Review Comment:
This was needed because `InternalWriter::create` could refer to either
`create(MessageType)` or `create(Schema, MessageType)`. Adding the ability to
pass `BiFunction<Schema, MessageType, ParquetValueWriter<?>>` to
`Parquet.createWriterFunc` caused compile failures because the calls were
ambiguous.
To solve the problem, I renamed this method so it is unambiguous. This has
not been in a release so it is safe. The `create(MessageType)` method has been
in a release so it is deprecated for removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
