Fokko commented on code in PR #1816:
URL: https://github.com/apache/iceberg-python/pull/1816#discussion_r2005760762
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -445,6 +462,14 @@ def files_affected(self) -> bool:
"""Indicate if any manifest-entries can be dropped."""
return len(self._deleted_entries()) > 0
+ def _validate(self, current_metadata: TableMetadata, snapshot:
Optional[Snapshot]) -> None:
+ if snapshot is None:
+ raise CommitFailedException("Snapshot cannot be None.")
Review Comment:
I think this is not correct. When you create an empty table, there is no
current-snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
