Fokko commented on code in PR #1816:
URL: https://github.com/apache/iceberg-python/pull/1816#discussion_r2005732527
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -239,7 +241,21 @@ def _summary(self, snapshot_properties: Dict[str, str] =
EMPTY_DICT) -> Summary:
truncate_full_table=self._operation == Operation.OVERWRITE,
)
+ def refresh(self) -> TableMetadata:
+ try:
+ table = self._transaction._table.refresh()
+ return table.metadata
+ except Exception:
+ return self._transaction._table.metadata
Review Comment:
Any specific reason to swallow this exception? If there are any errors, I
think it is likely that the commit will fail as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
