Fokko commented on code in PR #1816:
URL: https://github.com/apache/iceberg-python/pull/1816#discussion_r2003145037
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -445,6 +461,14 @@ def files_affected(self) -> bool:
"""Indicate if any manifest-entries can be dropped."""
return len(self._deleted_entries()) > 0
+ def _validate(self, current_metadata: TableMetadata, Snapshot:
Optional[Snapshot]) -> None:
+ if Snapshot is None:
+ raise ValueError("Snapshot cannot be None.")
Review Comment:
What do you think of:
```suggestion
raise CommitFailedException("Snapshot cannot be None.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
