Fokko commented on code in PR #1816:
URL: https://github.com/apache/iceberg-python/pull/1816#discussion_r2003145527


##########
pyiceberg/table/update/snapshot.py:
##########
@@ -239,7 +240,21 @@ def _summary(self, snapshot_properties: Dict[str, str] = 
EMPTY_DICT) -> Summary:
             truncate_full_table=self._operation == Operation.OVERWRITE,
         )
 
+    def refresh(self) -> TableMetadata:
+        try:
+            table = self._transaction._table.refresh()
+            return table.metadata
+        except Exception:
+            return self._transaction._table.metadata
+
+    @abstractmethod
+    def _validate(self, current_metadata: TableMetadata, Snapshot: 
Optional[Snapshot]) -> None: ...

Review Comment:
   Variable names should be lower-case:
   ```suggestion
       def _validate(self, current_metadata: TableMetadata, snapshot: 
Optional[Snapshot]) -> None: ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to