kevinjqliu commented on code in PR #1632:
URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2003800525
##########
pyiceberg/types.py:
##########
@@ -62,6 +63,12 @@
FIXED_PARSER = ParseNumberFromBrackets(FIXED)
+class TableVersion(IntEnum):
+ ONE = 1
+ TWO = 2
+ THREE = 3
Review Comment:
this is only used in `minimum_format_version`. maybe we can use the
`types.TableVersion` int literal for now and punt the enum discussion to #851
```
def minimum_format_version(self) -> TableVersion:
"""Minimum Iceberg format version after which this type is
supported."""
return 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
