Fokko commented on PR #1632:
URL: https://github.com/apache/iceberg-python/pull/1632#issuecomment-2736444700

   Looks like there is some issue with the `UnknownType`, we need to pass in 
the version there for the create table:
   
   ```
          tbl = catalog.create_table(
               identifier,
               schema=arrow_table.schema,
   +           properties={"format-version": "3"},
           )
   ```
   
   in `test_reads.py:1008`.
   
   I think this PR is ready to go. There are some parts we need to 
double-check, for example, the downcasting of micros to nanos, and that we 
don't have to fail for V3 when that isn't set. But since we don't yet support 
producing V3 metadata, I think that's okay.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to