Fokko commented on code in PR #1632: URL: https://github.com/apache/iceberg-python/pull/1632#discussion_r2003186605
########## pyiceberg/types.py: ########## @@ -62,6 +63,12 @@ FIXED_PARSER = ParseNumberFromBrackets(FIXED) +class TableVersion(IntEnum): + ONE = 1 + TWO = 2 + THREE = 3 Review Comment: I don't see a ton of added value in addition to using a `TypeAlias` like we have in typedef: https://github.com/apache/iceberg-python/blob/c06e32034fbd32d5aab9b2ef19ad2d253141479d/pyiceberg/typedef.py#L225 But I don't want to be that guy blocking this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
