flyrain commented on code in PR #12317:
URL: https://github.com/apache/iceberg/pull/12317#discussion_r1976039730
##########
api/src/main/java/org/apache/iceberg/types/PrimitiveHolder.java:
##########
@@ -21,7 +21,7 @@
import java.io.ObjectStreamException;
import java.io.Serializable;
-/** Replacement for primitive types in Java Serialization. */
+/** Replacement for primitive types and Variant type in Java Serialization. */
class PrimitiveHolder implements Serializable {
Review Comment:
I think it's worth considering a rename here—maybe something a bit more
general like `SimpleTypeHolder` or even just `TypeHolder`. Since it's not
public, the impact of renaming should be minimal anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
