aihuaxu commented on code in PR #12317:
URL: https://github.com/apache/iceberg/pull/12317#discussion_r1975827872
##########
api/src/main/java/org/apache/iceberg/types/PrimitiveHolder.java:
##########
@@ -21,7 +21,7 @@
import java.io.ObjectStreamException;
import java.io.Serializable;
-/** Replacement for primitive types in Java Serialization. */
+/** Replacement for primitive types and Variant type in Java Serialization. */
class PrimitiveHolder implements Serializable {
Review Comment:
Thanks @flyrain for review. I also thought about that. Since it's only used
internally and just two places - within type definition, I feel it's fine to
have a comment and leave like this. Let me know your thoughts and I can update
if needed. No preference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
