flyrain commented on code in PR #12317:
URL: https://github.com/apache/iceberg/pull/12317#discussion_r1974324857
##########
api/src/main/java/org/apache/iceberg/types/PrimitiveHolder.java:
##########
@@ -21,7 +21,7 @@
import java.io.ObjectStreamException;
import java.io.Serializable;
-/** Replacement for primitive types in Java Serialization. */
+/** Replacement for primitive types and Variant type in Java Serialization. */
class PrimitiveHolder implements Serializable {
Review Comment:
I think the name is a bit confusing. Maybe we could rename it to something
like `PrimitiveLikeHolder` `IdentityTypeHolder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
