XBaith commented on code in PR #12317:
URL: https://github.com/apache/iceberg/pull/12317#discussion_r1961023646
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -451,6 +452,10 @@ public VariantType asVariantType() {
return this;
}
+ Object writeReplace() throws ObjectStreamException {
+ return new PrimitiveHolder(toString());
Review Comment:
That's a great addition, but since `Variant` does not inherit from
`PrimitiveType`, I'm not sure if it will cause ambiguity with the name and
definition of the `PrimitiveHolder` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
