rdblue commented on PR #12374: URL: https://github.com/apache/iceberg/pull/12374#issuecomment-2675799837
> I think the one preference I would have is that if we're moving some of the type info (basic/logical/physical), I feel it would be better to move it inner enum to Variant interface so we have `Variant.BasicType` or `Variant.LogicalType` as opposed to just standalone enums. I agree. The reason for this is that they can't be package-private when nested in a class and I'm not yet sure whether we will expose the basic and logical types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
