jackye1995 commented on code in PR #12299:
URL: https://github.com/apache/iceberg/pull/12299#discussion_r1962195167
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputFile.java:
##########
@@ -82,6 +97,27 @@ public long getLength() {
@Override
public SeekableInputStream newStream() {
+ if (s3FileIOProperties().isS3AnalyticsAcceleratorEnabled()) {
+ LOG.info("Using S3 analytics accelerator stream");
Review Comment:
nit: should combine the separated log lines, and also it's usually not a
good practice to print all configs. If you want to do that, it should be at
debug level, and I am wondering if you can do that in your library instead of
in Iceberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
