jackye1995 commented on code in PR #12299:
URL: https://github.com/apache/iceberg/pull/12299#discussion_r1962191718
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -754,6 +773,14 @@ public boolean isRemoteSigningEnabled() {
return this.isRemoteSigningEnabled;
}
+ public boolean isS3AnalyticsAcceleratorEnabled() {
+ return isS3AnalyticsAcceleratorEnabled;
+ }
+
+ public Map<String, String> getS3AnalyticsacceleratorConfiguration() {
Review Comment:
nit: avoid `get` in method naming, and should use `properties` instead of
`configuration`, so this method should probably be
called`s3AnalyticsacceleratorProperties()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
