jackye1995 commented on code in PR #12299:
URL: https://github.com/apache/iceberg/pull/12299#discussion_r1962192384
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -640,6 +654,11 @@ public S3FileIOProperties(Map<String, String> properties) {
properties,
S3_DIRECTORY_BUCKET_LIST_PREFIX_AS_DIRECTORY,
S3_DIRECTORY_BUCKET_LIST_PREFIX_AS_DIRECTORY_DEFAULT);
+ this.isS3AnalyticsAcceleratorEnabled =
+ PropertyUtil.propertyAsBoolean(
+ properties, S3_ANALYTICS_ACCELERATOR_ENABLED,
S3_ANALYTICS_ACCELERATOR_ENABLED_DEFAULT);
+ this.s3AnalyticsacceleratorConfiguration =
+ PropertyUtil.propertiesWithPrefix(properties,
"s3.analyticsaccelerator.");
Review Comment:
nit: should use `-` to separate different words, so
"s3.analytics-accelerator."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
