jackye1995 commented on code in PR #12299: URL: https://github.com/apache/iceberg/pull/12299#discussion_r1962192776
########## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ########## @@ -72,6 +72,16 @@ public class S3FileIOProperties implements Serializable { public static final boolean S3_ACCESS_GRANTS_ENABLED_DEFAULT = false; + /** + * This property is used to enable using the S3 Analytics Accelerator library to accelerate data + * access from client applications to Amazon S3. + * + * <p>For more details, see: https://github.com/awslabs/analytics-accelerator-s3 + */ + public static final String S3_ANALYTICS_ACCELERATOR_ENABLED = "s3.analyticsaccelerator.enabled"; Review Comment: nit: should use - to separate different words, so "s3.analytics-accelerator.enabled" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org