RussellSpitzer commented on code in PR #12319:
URL: https://github.com/apache/iceberg/pull/12319#discussion_r1960686497
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -540,7 +543,7 @@ public static void importSparkTable(
try {
PartitionSpec spec =
- SparkSchemaUtil.specForTable(spark,
sourceTableIdentWithDB.unquotedString());
Review Comment:
I think we have a strong case for deprecating `specForTable` and
`schemaForTable` both are currently public static and used only for this method
inside of Iceberg Spark. I'm not sure what other users are using these methods
for, but because of how they are essentially broken I think we should remove
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
