RussellSpitzer commented on code in PR #12319:
URL: https://github.com/apache/iceberg/pull/12319#discussion_r1960682985
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -968,6 +1024,28 @@ public void testAddFilesPartitionedWithParallelism() {
sql("SELECT id, name, dept, subdept FROM %s ORDER BY id", tableName));
}
+ @TestTemplate
+ public void testAddFilesToTableWithManySpecs() {
+ createPartitionedHiveTable();
+ createIcebergTable("id Integer, name String, dept String, subdept
String"); // Spec 0
+
+ sql("ALTER TABLE %s ADD PARTITION FIELD id", tableName); // Spec 1
+ sql("ALTER TABLE %s ADD PARTITION FIELD name", tableName); // Spec 2
+ sql("ALTER TABLE %s ADD PARTITION FIELD subdept", tableName); // Spec 3
+
+ List<Object[]> result =
+ sql(
+ "CALL %s.system.add_files('%s', '%s', map('id', 1))",
+ catalogName, tableName, sourceTableName);
+
+ assertOutput(result, 2L, 1L);
+
+ assertEquals(
Review Comment:
This test would simply fail before. AddFiles would use the wrong specId and
contain incorrect partition data. Now it correctly assigns a matching partition
spec to the newly added files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
