RussellSpitzer commented on code in PR #12319: URL: https://github.com/apache/iceberg/pull/12319#discussion_r1960679959
########## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java: ########## @@ -476,6 +485,53 @@ public void addPartitionToPartitionedSnapshotIdInheritanceEnabledInTwoRuns() { sql("SELECT id, name, dept, subdept FROM %s WHERE id < 3 ORDER BY id", sourceTableName), sql("SELECT id, name, dept, subdept FROM %s ORDER BY id", tableName)); + Table table = Spark3Util.loadIcebergTable(spark, tableName); + FileIO io = ((HasTableOperations) table).operations().io(); + + assertThat( Review Comment: This test actually passes this clause before my PR because it loads the source table as a "File" table and not as a "Spark" table. The test below uses a Hive table which fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org