rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1955196818


##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -712,6 +712,10 @@ public T map(Types.MapType map, Supplier<T> keyResult, 
Supplier<T> valueResult)
       return null;
     }
 
+    public T variant(Types.VariantType variant) {
+      throw new UnsupportedOperationException("Unsupported type: variant");

Review Comment:
   Looks like this is not yet implemented by:
   * `CheckCompatibility` (tested by `TestReadabilityChecks`)
   * `FixupTypes`, `SparkFixupTypes`, or `FlinkFixupTypes`
   * ~~`PruneColumnsWithoutReordering` (Spark, so maybe this can be done 
separately)~~
   * `ReassignDoc`
   * `AssignIds`
   
   It is also not implemented by `PruneColumnsWithReordering` but that doesn't 
appear to be referenced anywhere. I opened #12258 to remove these.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to