rdblue commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1958673483
##########
api/src/main/java/org/apache/iceberg/types/PrimitiveHolder.java:
##########
@@ -33,6 +33,6 @@ class PrimitiveHolder implements Serializable {
}
Object readResolve() throws ObjectStreamException {
- return Types.fromPrimitiveString(typeAsString);
+ return Types.fromTypeName(typeAsString);
Review Comment:
This is tested by `TestSerializableTypes`. Can you add new cases for variant
(and the other new types, while you're updating it)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
