aihuaxu commented on code in PR #11831: URL: https://github.com/apache/iceberg/pull/11831#discussion_r1960134459
########## api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java: ########## @@ -46,6 +46,7 @@ public void testIdentityTypes() throws Exception { Types.StringType.get(), Types.UUIDType.get(), Types.BinaryType.get(), + Types.UnknownType.get() Review Comment: Variant test is already added below. Since for variant, we need to test with isEqualTo() instead of isSameAs(). > public void testVariant() throws Exception { -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org