aihuaxu commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1958636578
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -712,6 +712,10 @@ public T map(Types.MapType map, Supplier<T> keyResult,
Supplier<T> valueResult)
return null;
}
+ public T variant(Types.VariantType variant) {
+ throw new UnsupportedOperationException("Unsupported type: variant");
Review Comment:
Added the implementations other than PruneColumnsWithoutReordering. For
FixupTypes for Spark/Flink, there is no fixup for Variant and I didn't add
coverage for it, unless we just want to test out the exception is not thrown.
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -616,8 +616,8 @@ public T map(Types.MapType map, T keyResult, T valueResult)
{
return null;
}
- public T variant() {
- return null;
+ public T variant(Types.VariantType variant) {
+ throw new UnsupportedOperationException("Unsupported type: variant");
Review Comment:
Added `CreateMapping` and `DescribeSchemaVisitor` visitor implementation. I
will try to address the remaining from different modules separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
