HonahX commented on code in PR #12177:
URL: https://github.com/apache/iceberg/pull/12177#discussion_r1956840017
##########
parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java:
##########
@@ -56,6 +56,10 @@ public class TypeToMessageType {
LogicalTypeAnnotation.timestampType(false /* not adjusted to UTC */,
TimeUnit.MICROS);
private static final LogicalTypeAnnotation TIMESTAMPTZ_MICROS =
LogicalTypeAnnotation.timestampType(true /* adjusted to UTC */,
TimeUnit.MICROS);
+ // According to
+ //
https://github.com/apache/parquet-java/blob/7f77908338192105a5adbfc420a7281d919e8596/parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java#L992-L996
+ // This maps to UNKNOWN
+ private static final LogicalTypeAnnotation UNKNOWN =
LogicalTypeAnnotation.intervalType();
Review Comment:
So in the attempt I did I use different schema for `parquetSchema` and
writerFactory
```
/ The third parameter is for ignoreUnknown = true
this.parquetSchema = ParquetSchemaUtil.convert(schema, "table", true);
this.model =
(ParquetValueWriter<T>)
createWriterFunc.apply(ParquetSchemaUtil.convert(schema, "table"));
```
This way the created parquet will not have the "unknown" column in the
schema. Will think more about these tomorrow 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
