nastra commented on code in PR #12177:
URL: https://github.com/apache/iceberg/pull/12177#discussion_r1943308448


##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetDataWriter.java:
##########
@@ -109,16 +123,34 @@ public void testDataWriter() throws IOException {
         .as("Sort order should match")
         .isEqualTo(sortOrder.orderId());
     assertThat(dataFile.keyMetadata()).as("Key metadata should be 
null").isNull();
+    assertThat(dataFile.nullValueCounts().containsKey(4))

Review Comment:
   ```suggestion
       assertThat(dataFile.nullValueCounts()).doesNotContainKey(4)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to