Fokko commented on code in PR #12177:
URL: https://github.com/apache/iceberg/pull/12177#discussion_r1942552123
##########
parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java:
##########
@@ -56,6 +56,10 @@ public class TypeToMessageType {
LogicalTypeAnnotation.timestampType(false /* not adjusted to UTC */,
TimeUnit.MICROS);
private static final LogicalTypeAnnotation TIMESTAMPTZ_MICROS =
LogicalTypeAnnotation.timestampType(true /* adjusted to UTC */,
TimeUnit.MICROS);
+ // According to
+ //
https://github.com/apache/parquet-java/blob/7f77908338192105a5adbfc420a7281d919e8596/parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java#L992-L996
+ // This maps to UNKNOWN
+ private static final LogicalTypeAnnotation UNKNOWN =
LogicalTypeAnnotation.intervalType();
Review Comment:
Reusing the `interval` doesn't feel right to me 🤔
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java:
##########
@@ -386,6 +390,20 @@ public void write(int repetitionLevel, UUID value) {
}
}
+ private static class UnknownWriter extends PrimitiveWriter<Object> {
+ private UnknownWriter(ColumnDescriptor desc) {
+ super(desc);
+ }
+
+ @Override
+ public void write(int repetitionLevel, Object value) {}
+
+ @Override
+ public List<TripleWriter<?>> columns() {
+ return ImmutableList.of();
+ }
+ }
Review Comment:
Instead of adding the actual writers, I think it would be better to see if
we can just skip over the column when creating a writer in
`BaseParquetWriter.createWriter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
