Fokko commented on code in PR #12177:
URL: https://github.com/apache/iceberg/pull/12177#discussion_r1946736204
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java:
##########
@@ -386,6 +390,20 @@ public void write(int repetitionLevel, UUID value) {
}
}
+ private static class UnknownWriter extends PrimitiveWriter<Object> {
+ private UnknownWriter(ColumnDescriptor desc) {
+ super(desc);
+ }
+
+ @Override
+ public void write(int repetitionLevel, Object value) {}
+
+ @Override
+ public List<TripleWriter<?>> columns() {
+ return ImmutableList.of();
+ }
+ }
Review Comment:
I've played around with the code today, and I see the problem that you're
encountering. Unfortunally, for the `createWriterFunc` we have the Parquet
`MessageType` as an input, otherwise, we could skip over the Unkown fields
pretty easily.
I think 1 could work, but we have to make sure that field doesn't leak into
the Parquet schema (which is not allowed according to the spec).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
