Fokko commented on PR #12127: URL: https://github.com/apache/iceberg/pull/12127#issuecomment-2636126820
> I have a different read according to that https://infra.apache.org/licensing-howto.html#bundled-vs-non-bundled as we are talking about bundle dependencies. This is very confusing since this PR alters the `LICENSE` of the non-bundled JARs. The bundle-JARs already have their own `LICENCE` and `NOTICE`. After this PR, the `iceberg-core` library doesn't have anything in the `LICENSE`, but this is incorrect as I've pointed out here: https://github.com/apache/iceberg/pull/12169#issuecomment-2633771511 The `Tasks.java` comes from Presto and should have a mention. > Also, we could consider only the applicable jar: as said presto code copy is valid for spark only so why including in other jars ? This is incorrect as mentioned https://github.com/apache/iceberg/pull/12169#issuecomment-2633771511. It includes for `iceberg-core`, `iceberg-spark` and `iceberg-aws`. > If we are very strict, as commented in another PR, that should be done this way. I don't think we should have a LICENSE per JAR since we would also need to combine them again. For example, the `aws-bundle` would have two mentioned Presto `NOTICE` twice; one coming from `iceberg-core` and one from `iceberg-aws`. > To illustrate that, see parquet: parquet-avro includes LICENSE/NOTICE documenting Avro, but other parquet artifacts doesn't provide LICENSE/NOTICE (which is bad), but parquet-jackson mentions Jackson. So this is correct here imho (even if LICENSE/NOTICE should be present in all distributed jar). Could you elaborate on that example? AFAIK [parquet-java](https://github.com/apache/parquet-java) also has a [single `NOTICE`](https://github.com/apache/parquet-java/blob/3306fd605731a19aab0f0dc1f01feffa842362e6/NOTICE#L29-L36) because we copied code from the Avro repository (that makes it bundled). I think it is much better to include the source `LICENSE`/`NOTICE` in all the non-bundled jars (everything, excluding `*-bundle`, `*-runtime`). This puts more burden on downstream projects because they have to do a bit more work when they [bundle](https://infra.apache.org/licensing-howto.html#alv2-dep): If the dependency supplies a `NOTICE` file, its contents must be analyzed and the relevant portions bubbled up into the top-level `NOTICE` file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
