jbonofre commented on PR #12127: URL: https://github.com/apache/iceberg/pull/12127#issuecomment-2623934585
> From my reading of https://infra.apache.org/licensing-howto.html#source-tree-location technically this is correct. The gradlew dependency is bundled with the source distribution which the root level LICENSE/NOTICE addresses. For the rest of the jars (excluding bundle/runtime) we'd need a separate LICENSE/NOTICE that doesn't refer to gradlew. > > Just had a comment on calling the new folder something else to distinguish that the license documents in that folder are speciifcally for binary distributions The source distribution is good (I did a full review on that). Yes, my point is for non-bundle/non-runtime jar files that should use clean LICENSE/NOTICE (remember, we should not include content in LICENSE/NOTICE which not strictly required). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
