amogh-jahagirdar commented on code in PR #12127: URL: https://github.com/apache/iceberg/pull/12127#discussion_r1934737242
########## licenses/LICENSE: ########## @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 + http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, Review Comment: I guess there's no definite practice? Spark calls https://github.com/apache/spark/tree/master/licenses-binary But Flink just puts them under licenses https://github.com/apache/flink/tree/master/licenses My stance is if there's a known practice we should just follow that, if there's not, I feel like it makes sense to just call it binary-licenses or something like that? cc @rdblue @danielcweeks ########## licenses/LICENSE: ########## @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 + http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, Review Comment: I guess there's no definite practice? Spark calls https://github.com/apache/spark/tree/master/licenses-binary But Flink just puts them under licenses https://github.com/apache/flink/tree/master/licenses My stance is if there's a known practice we should just follow that, if there's not, I feel like it makes sense to just call it binary-licenses or something like that? cc @rdblue @danielcweeks @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
