mxm commented on code in PR #12049:
URL: https://github.com/apache/iceberg/pull/12049#discussion_r1940813339
##########
data/src/test/java/org/apache/iceberg/data/DataTest.java:
##########
@@ -59,6 +63,10 @@ protected boolean supportsDefaultValues() {
return false;
}
+ protected boolean supportsRequiredTypes() {
Review Comment:
Good point to be specific. I have renamed this method to
`allowsWritingNullValuesForRequiredFields()`.
##########
data/src/test/java/org/apache/iceberg/data/orc/TestGenericData.java:
##########
@@ -54,13 +54,23 @@
public class TestGenericData extends DataTest {
+ @Override
+ protected boolean supportsRequiredTypes() {
Review Comment:
Added. The Orc writers also run this test now, as it is expected for them to
support writing null values for required fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
