stevenzwu commented on code in PR #12049:
URL: https://github.com/apache/iceberg/pull/12049#discussion_r1940304992
##########
data/src/test/java/org/apache/iceberg/data/DataTest.java:
##########
@@ -59,6 +63,10 @@ protected boolean supportsDefaultValues() {
return false;
}
+ protected boolean supportsRequiredTypes() {
Review Comment:
Alternatively, we can remove this boolean flag method. just override the
test method in the `orc` test code and modify the expected behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
