stevenzwu commented on code in PR #12049:
URL: https://github.com/apache/iceberg/pull/12049#discussion_r1940303839
##########
data/src/test/java/org/apache/iceberg/data/orc/TestGenericData.java:
##########
@@ -54,13 +54,23 @@
public class TestGenericData extends DataTest {
+ @Override
+ protected boolean supportsRequiredTypes() {
Review Comment:
if possible, maybe add some Javadoc to explain why the behavior is different
for ORC and hence have to disable the `testWriteNullValueForRequiredType` from
the base class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
