mxm commented on code in PR #12049:
URL: https://github.com/apache/iceberg/pull/12049#discussion_r1938268635
##########
data/src/test/java/org/apache/iceberg/data/DataTest.java:
##########
@@ -486,4 +490,22 @@ public void
testPrimitiveTypeDefaultValues(Type.PrimitiveType type, Object defau
writeAndValidate(writeSchema, readSchema);
}
+
+ @Test
+ public void testWriteNullValueForRequiredType() {
+ Assumptions.assumeThat(supportsDefaultValues()).isTrue();
Review Comment:
I've replaced it with `supportsRequiredValues()`. There is actually only one
class, `org.apache.iceberg.data.orc.TestGenericData` which does not support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
