mattmartin14 commented on code in PR #1534:
URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1937574646
##########
pyiceberg/table/__init__.py:
##########
@@ -1064,6 +1064,119 @@ def name_mapping(self) -> Optional[NameMapping]:
"""Return the table's field-id NameMapping."""
return self.metadata.name_mapping()
+ def merge_rows(self, df: pa.Table, join_cols: list
+ , when_matched_update_all: bool = True
Review Comment:
@tscottcoombes1 - I think the group as a whole has aligned on a directional
statement that we want the merge_rows function in pyiceberg to cover the basic
merge commands (e.g. update all/insert all). For more complicated merge
predicates, I believe we aligned on telling users to go use pyspark at that
point.
@Fokko @kevinjqliu - what are your thoughts though on @tscottcoombes1
suggestion above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
