mattmartin14 commented on code in PR #1534:
URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1935767110
##########
pyiceberg/table/__init__.py:
##########
@@ -1064,6 +1064,119 @@ def name_mapping(self) -> Optional[NameMapping]:
"""Return the table's field-id NameMapping."""
return self.metadata.name_mapping()
+ def merge_rows(self, df: pa.Table, join_cols: list
Review Comment:
@Fokko i chose "merge_rows" because when i looked through the table init.py
file, i saw a lot of areas that had "merge" in it already e.g.
"manifest_merge_enabled", "merge_append()", etc.
I figured it would be better to be more verbose in this case to say
"merge_rows" vs. just "merge" as that might confuse others later when the look
through the code.
Do you agree with this or do you still think we should change the function
name to "merge" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
