mattmartin14 commented on PR #1534: URL: https://github.com/apache/iceberg-python/pull/1534#issuecomment-2627741926
@Fokko - I've updated the PR to include the pred code you provided to pre-filter the iceberg table, thus avoid loading it all into memory. I was also able to borrow that same pred code as the overwrite_filter later down. Thanks; i think this PR is starting to look in good shape. The only oustanding items I see are if we want to rename "merge_rows" to "merge". I added some comments on that thread and would like to know your thoughts. Thanks, Matt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
