ebyhr commented on code in PR #12117:
URL: https://github.com/apache/iceberg/pull/12117#discussion_r1931404006
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkDaysFunction.java:
##########
@@ -39,6 +39,9 @@ public void testDates() {
assertThat(scalarSql("SELECT system.days(date('2017-12-01'))"))
.as("Expected to produce 2017-12-01")
.isEqualTo(Date.valueOf("2017-12-01"));
+ assertThat(scalarSql("SELECT system.day(date('2017-12-01'))"))
Review Comment:
Can we also update negative test cases? e.g. testWrongNumberOfArguments
The error message always uses plural names because function name is
hard-coded in `name()` and `canonicalName()` methods in each function class. We
may want to add a constructor taking the function name to report the correct
function name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
