Fokko commented on code in PR #12117:
URL: https://github.com/apache/iceberg/pull/12117#discussion_r1939119884
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -70,7 +70,8 @@
public class SparkV2Filters {
public static final Set<String> SUPPORTED_FUNCTIONS =
- ImmutableSet.of("years", "months", "days", "hours", "bucket",
"truncate");
+ ImmutableSet.of(
+ "year", "years", "month", "months", "day", "days", "hour", "hours",
"bucket", "truncate");
Review Comment:
Hey @wypoon thanks for working on this. Initially, we went for the plural
form because the singular form is already a function in Spark (e.g.
[day](https://spark.apache.org/docs/latest/api/sql/index.html#day)), do you
know if these interfere? We should also make sure that we convert this in the
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
