wypoon commented on code in PR #12117:
URL: https://github.com/apache/iceberg/pull/12117#discussion_r1937934388
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -70,7 +70,8 @@
public class SparkV2Filters {
public static final Set<String> SUPPORTED_FUNCTIONS =
- ImmutableSet.of("years", "months", "days", "hours", "bucket",
"truncate");
+ ImmutableSet.of(
+ "year", "years", "month", "months", "day", "days", "hour", "hours",
"bucket", "truncate");
Review Comment:
I wasn't aware of the hardcoded references to "years", "months", "days" and
"hours" in `SparkV2Filters`.
The changes here in `SparkV2Filters` are only necessary if we want to make
the singular forms the standard.
Right now, I have left the plural forms as standard.
@rdblue should we make the singular form of the functions the standard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
