aihuaxu commented on code in PR #11831:
URL: https://github.com/apache/iceberg/pull/11831#discussion_r1937744616
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -61,6 +61,14 @@ private Types() {}
private static final Pattern DECIMAL =
Pattern.compile("decimal\\(\\s*(\\d+)\\s*,\\s*(\\d+)\\s*\\)");
+ public static Type typeFromTypeString(String typeString) {
Review Comment:
@amogh-jahagirdar Do you prefer to add a new `fromTypeString` or change
`fromPrimitiveString` to `fromTypeString` (that introduces incompatibility in
the api)? Would it be fine to introduce incompatibility - assume that will be
in 1.8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
