swapna267 commented on code in PR #12116:
URL: https://github.com/apache/iceberg/pull/12116#discussion_r1934451707
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java:
##########
@@ -53,7 +54,8 @@ public class IcebergTableSource
implements ScanTableSource,
SupportsProjectionPushDown,
SupportsFilterPushDown,
- SupportsLimitPushDown {
+ SupportsLimitPushDown,
+ SupportsSourceWatermark {
Review Comment:
These features were driven by mainly a use case, where an iceberg table is
needed to be used in Flink window functions. This needs an incoming table to
have MILLISECOND precision timestamp column and also watermark to be defined on
source table.
As iceberg only supports MICROSECOND timestamp columns, we need to have a
table with computed columns and we can create these only in Flink Catalog.
Iceberg catalog doesn't support creating tables with computed columns.
That said, i am happy to split them into 2 separate PR's.
I have tests for CREATE TABLE LIKE.
As Watermark support is just making Source to implement interface and
falling back to https://github.com/apache/iceberg/pull/9346 for core logic, i
didn't have a test case. I can add a validation on if `watermark-column` is
configured or not , so it can fail fast. And a test case around that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
