pvary commented on code in PR #12116: URL: https://github.com/apache/iceberg/pull/12116#discussion_r1936872361
########## flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/TestIcebergConnector.java: ########## @@ -256,43 +256,6 @@ public void testCatalogDatabaseConflictWithFlinkDatabase() { .hasMessageStartingWith("Could not execute CreateTable in path"); } - @TestTemplate - public void testConnectorTableInIcebergCatalog() { - // Create the catalog properties - Map<String, String> catalogProps = Maps.newHashMap(); Review Comment: I think that this is still a valid check in most cases. Only not valid when the table is created with "CREATE TABLE.. LIKE" and only if the source table is an iceberg table. Do I miss something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org