pvary commented on code in PR #12116:
URL: https://github.com/apache/iceberg/pull/12116#discussion_r1933513558
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java:
##########
@@ -53,7 +54,8 @@ public class IcebergTableSource
implements ScanTableSource,
SupportsProjectionPushDown,
SupportsFilterPushDown,
- SupportsLimitPushDown {
+ SupportsLimitPushDown,
+ SupportsSourceWatermark {
Review Comment:
I think we have 2 feature in a single PR:
- CREATE TABLE LIKE
- Watermark support
Could we separate out these features to different PRs?
Could we write tests for both features?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
