zhjwpku commented on PR #32: URL: https://github.com/apache/iceberg-cpp/pull/32#issuecomment-2611699882
> TBH, I'm not in favor of adding `[[nodiscard]]` every where. It is boring to type it for every function and make the function signature too verbose. How about only adding `[[nodiscard]]` to functions that will lead to fatal error if return values are discarded? Make sense, maybe we can depend on `-Wno-unused-result` to let compiler warn if function return value is not used. As for the user interfaces, I think we should add `[[nodiscard]]`. @lidavidm thoughts? > > See https://stackoverflow.com/questions/77242978/what-are-the-common-practices-and-considerations-for-using-the-nodiscard-att -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
